up209d / ResourcesSaverExt

Chrome Extension for one click downloading all resources files and keeping folder structures.
GNU General Public License v3.0
1.65k stars 337 forks source link

Crashes when there's thousands of files #47

Open lozenge0 opened 2 years ago

lozenge0 commented 2 years ago

Not sure if it's some sort of overflowing buffer or it just needs to be throttled but if you have like 4000 assets on the site and some of which are large it will just crash

nooooooom commented 2 years ago

I think it may be because the number of files is too large or the total resources are too large, which causes the browser to crash. The way I deal with it is, I changed the source code of ResourcesSaverExt to divide the number of files packaged each time into multiple sub-packages, and only package 1000 -10000 files each time (depending on the computer configuration),

getAllToDownloadContent(toDownload.splice(0, 1000), function (result) {

and then merge all the packages.

nooooooom commented 1 year ago

In the latest version, this problem no longer occurs! At least it didn't appear during my use!