upa-url / upa

An implementation of the WHATWG URL Standard in C++
https://upa-url.github.io/docs/
Other
13 stars 0 forks source link

Add support for ICU library bundled with Windows #49

Closed rmisev closed 4 months ago

rmisev commented 4 months ago

This adds the cmake option variable UPA_USE_WINDOWS_ICU and a preprocessor macro of the same name for this purpose:

  1. For cmake CLI add the option -DUPA_USE_WINDOWS_ICU=ON
  2. Or define the preprocessor macro UPA_USE_WINDOWS_ICU = 1 if you are using amalgamated sources
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.65%. Comparing base (c9b7de4) to head (b71aca6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #49 +/- ## ======================================= Coverage 99.65% 99.65% ======================================= Files 16 16 Lines 2333 2333 Branches 387 387 ======================================= Hits 2325 2325 Misses 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.