uparma / uparma-lib

Lookup library for all mappers. Format json
3 stars 6 forks source link

add missing translation for ptm shepherd style header translations #122

Closed tristan-ranff closed 1 year ago

StSchulze commented 1 year ago

Just as a quick note on "modifications": In Ursgal 1, we had kept "Modifications" and "Assigned Modifications" (translated as "Mass Difference Annotations" in Ursgal 1) separate, for two reasons:

  1. They are conceptually different. The former refers to modifications that were included in the search, while the latter comes from mass differences mapped to modifications after the search.
  2. The mapped modifications are not necessarily unimod names, i.e. the names can be different from what is stored in the unimod.xml and/or userdefined_unimod.xml.

I'd of course be open to dealing with this in a different way in Ursgal 2, but just wanted to give a heads up on potential issues for the unify/pyprotista/pyiohat step.