search

uparma / uparma-lib

Lookup library for all mappers. Format json
3 stars 6 forks source link

X!Tandem header translations are missing #18

Closed MKoesters closed 3 years ago

MKoesters commented 3 years ago

Seems like they never were there, at least I cant find them in ursgal. Is there any special reason they are not here or should we add them?

StSchulze commented 3 years ago

The historical reason (as far as I know) why they aren't there is that the output of xtandem isn't a csv, i.e. there are no headers to translate, and the output of the xtandem2csv engine already has the correct headers. But of course that's not a very logical argument, since there's still a translation, just in xtandem2csv.

Long story short: I think it should be added, yes.

ArtiVlasov commented 3 years ago

Merged & closed ;)