search

upb-uc4 / lagom-core

Repository for the micro service backend using lagom.
Apache License 2.0
6 stars 0 forks source link

Duplicate MatriculationID not rejected #292

Closed tobias-wiese closed 4 years ago

tobias-wiese commented 4 years ago

Describe the bug When creating a student account with matnr "1234567", there is already matriculation data given. This happens if you add a student with a matnr that was in use and has matriculation data (on the chain). Conflicts with matnr currently in use result in an error as it should be.

Expected behavior Should get an error, that the matnr was already been used (there is data for that ID)

Screenshots If applicable, add screenshots to help explain your problem. grafik

Desktop (please complete the following information):

Additional context Tested against experimental deployment

dhelmert commented 4 years ago

This Bug can be fixed once we implement the feature that users cannot be completely deleted, but rather flagged as deleted

lrschaef commented 4 years ago

We now use the enrollmentID instead of the matriculation ID for storing matriculation data, therefore this bug can no longer occur.