Feature/exam reg service - Githubissues

upb-uc4 / lagom-core

Repository for the micro service backend using lagom.

Apache License 2.0

6 stars 0 forks source link

Feature/exam reg service #373

Closed dhelmert closed 3 years ago

dhelmert commented 3 years ago

Reason for this PR

A new service to support examination regulations is needed for course enrollment and the exam service, both goals of our current development

Changes in this PR

Created Examination Regulation Service with endpoints for:
- getting ExaminationRegulations
- getting list of names of ExaminationRegulations
- getting a list of Modules
  All with a some query parameters
Course Service:
- Added "moduleIds" to Course object
- Added query parameter for module Ids
- Added dependency; CourseService dependant on ExamReg
[X] Test written
[X] Changelog updated

dhelmert commented 3 years ago

CourseServiceSpec is missing a test for the module ID filter on get all courses

The tests have been added, and resulted in discovering an error in the filtering. Good find!