upbound / function-cidr

Composition Function that transforms CIDRs
Apache License 2.0
4 stars 3 forks source link

feat(base): update base image #3

Closed haarchri closed 7 months ago

haarchri commented 7 months ago

Description of your changes

update base image

Fixes #

I have:

How has this code been tested

make all
docker build . --quiet --platform=linux/amd64 --tag runtime-amd64
sha256:7dece00027fa52c1317db908994d54c77a36cc2b2e4105838f4842abc7eadee3
docker build . --quiet --platform=linux/arm64 --tag runtime-arm64
sha256:247edc0d959354caac0c83930a5f682e40e3bece2ed0988b902b8a6346a288d8
crossplane xpkg build \
                                --package-root=package \
                                --embed-runtime-image=runtime-arm64 \
                                --package-file=function-arm64.xpkg
up xpkg push "xpkg.upbound.io/upbound/function-cidr":"v0.1.0" -f "function-arm64.xpkg"
xpkg pushed to xpkg.upbound.io/upbound/function-cidr:v0.1.0
humoflife commented 7 months ago

The syntax notation does not seem to be universally understood with and without docker buildkit enabled.

DOCKER_BUILDKIT=1 docker buildx build .
[+] Building 0.0s (1/1) FINISHED                                  docker:desktop-linux
 => [internal] load build definition from Dockerfile                              0.0s
 => => transferring dockerfile: 988B                                              0.0s
Dockerfile:1
--------------------
   1 | >>> syntax=docker/dockerfile:1
   2 |     # Above replaces FROM golang:1.21 as build-stage
   3 |
--------------------
ERROR: failed to solve: dockerfile parse error on line 1: unknown instruction: syntax=docker/dockerfile:1
haarchri commented 7 months ago

It's the dockerfile from our function templates repo

ytsarev commented 7 months ago

Good catch! Unfortunately, I missed this PR before. The Dockerfile update is already solved in https://github.com/upbound/function-cidr/pull/1 where I added the similar commit + additional change to fix and test the pipelines. Closing.