Closed haarchri closed 7 months ago
The syntax notation does not seem to be universally understood with and without docker buildkit enabled.
DOCKER_BUILDKIT=1 docker buildx build .
[+] Building 0.0s (1/1) FINISHED docker:desktop-linux
=> [internal] load build definition from Dockerfile 0.0s
=> => transferring dockerfile: 988B 0.0s
Dockerfile:1
--------------------
1 | >>> syntax=docker/dockerfile:1
2 | # Above replaces FROM golang:1.21 as build-stage
3 |
--------------------
ERROR: failed to solve: dockerfile parse error on line 1: unknown instruction: syntax=docker/dockerfile:1
It's the dockerfile from our function templates repo
Good catch! Unfortunately, I missed this PR before. The Dockerfile update is already solved in https://github.com/upbound/function-cidr/pull/1 where I added the similar commit + additional change to fix and test the pipelines. Closing.
Description of your changes
update base image
Fixes #
I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested