upbound / provider-terraform

A Crossplane provider for Terraform
https://marketplace.upbound.io/providers/upbound/provider-terraform/
Apache License 2.0
151 stars 59 forks source link

Ability to override terraform version per Workspace with environment variable #254

Closed ytsarev closed 2 months ago

ytsarev commented 7 months ago

Description of your changes

Fixes #84

I have:

How has this code been tested

Running custom provider image with this change and invoking several workspace examples

k get workspaces.tf.upbound.io
NAME                           SYNCED   READY   AGE
sample-inline-with-env         True     True    26m
sample-inline-own-tf-version   True     True    19m

Checked the associated contents of /.tenv directory and custom terraform cli invocation in the process list - it worked as expected.

bdwyertech commented 7 months ago

Hey this looks really cool, thanks for the shout out @ytsarev

ytsarev commented 7 months ago

/test-examples="examples/workspace-inline-aws.yaml"

turkenf commented 6 months ago

/test-examples="examples/workspace-inline-aws.yaml"

FYI: This test comment was just left to make sure pipelines work.

jeanduplessis commented 2 months ago

At this point in time, we will not allow overriding the Terraform binary with the possibility of one released after 1.5.x as they are released under the BSL license. This provider would violate the license terms, and we do not want to open the possibility for that even if the action was taken by a user of the provider.