upbound / provider-terraform

A Crossplane provider for Terraform
https://marketplace.upbound.io/providers/upbound/provider-terraform/
Apache License 2.0
151 stars 59 forks source link

feat: introduce json format for inline module (#165) #283

Closed denniskniep closed 2 months ago

denniskniep commented 3 months ago

Description of your changes

API Change: Added a new property InlineFormat to WorkspaceParameters which specifies the format of the inline Terraform content. It could be HCL or JSON

Change: If InlineFormat is set to JSON the file which is created is named main.tf.json instead of main.tf

Fixes #165

I have:

How has this code been tested

Wrote a UnitTest and already tested it in my environment

Upbound-CLA commented 3 months ago

CLA assistant check
All committers have signed the CLA.

denniskniep commented 3 months ago

@bobh66 addressed your review comments

denniskniep commented 2 months ago

@bobh66 can we merge this?