upbound / up

The @upbound CLI
Apache License 2.0
52 stars 41 forks source link

Fix linter errors and separate kubeconfig generation steps #297

Closed muvaf closed 1 year ago

muvaf commented 1 year ago

Description of your changes

I needed to separate the kubeconfig steps as I needed to construct a kube client but then one thing led to another and I had to do a big linter pass to make make reviewable pass. This included import ordering, some changes in the interfaces and addition of context.Context in places where it was deemed necessary by the contextcheck golinter.

I have:

How has this code been tested

Only meaningful change is made in kubeconfig generation and I tested that manually and confirmed that it's working in the same way.