upbound / up

The @upbound CLI
Apache License 2.0
52 stars 41 forks source link

Update gitsources login to pass port parameter. #299

Closed AlainRoy closed 1 year ago

AlainRoy commented 1 year ago

Description of your changes

Update gitsources login to pass port parameter

This completes the work started earlier to allow users to authorize and install the GitHub app when making a configuration. Previously, the experience was janky because we didn't get a callback from MCP when the process completed. MCP has been updated to take a new "cli" parameter that specifies a port, and this results in us getting that callback and having a smoother user experience.

As a pleasant side-effect, the code got much simpler.

I have:

How has this code been tested

Manual testing in local-dev and dev.