upbound / up

The @upbound CLI
Apache License 2.0
52 stars 41 forks source link

Create a token as part of connect command #303

Closed muvaf closed 1 year ago

muvaf commented 1 year ago

Description of your changes

We require the user to create a new token for connection but up CLI is already logged in to use this command, so we can just create a new one unless they provide it via --token.

This change also accommodates the recent changes in MCP connector that dumb down the logic here to make it easier to install MCP Connector using Helm so that we can better integrate with ArgoCD, provider-helm and others by constructing the kubeconfig as part of the Helm chart rather than expecting a Secret to contain it.

In addition, bind command has been removed. By default, MCP Connector binds all XRDs automatically https://github.com/upbound/mcp-connector/issues/32 . Users can disable it via a Helm flag.

All that reduced the whole connection flow to a single command:

up alpha ctp connect my-control-plane my-app-cl-1

Fixes https://github.com/upbound/mcp-connector/issues/38

I have:

How has this code been tested

Manually tested.