upbound / up

The @upbound CLI
Apache License 2.0
52 stars 41 forks source link

`--auth-ext` flag when building an xpkg mutates the `package.yaml` when passed a file that is part of the package #319

Open jastang opened 1 year ago

jastang commented 1 year ago

What happened?

This is more of an edge case, but I wanted to see what would happen if I passed the definition.yaml on a Configuration package I was building as the annotations file:

up xpkg build --output test -f ~/workspace/xplane/package-noop --auth-ext="/Users/jasontang/workspace/xplane/package-noop/definition.yaml"

While the package was built without error, I was surprised to see that the digest was different from the package I built without passing any annotations file. Turns out that the contents of definition.yaml were omitted from the package.yaml, resulting in a smaller package size. I would expect this to be a no-op, or an appropriate error being returned if the validation of the contents failed.

How can we reproduce it?

Build an xpkg and pass a YAML file that is part of the package to the --auth-ext flag.

What environment did it happen in?

mainline