Closed tnthornton closed 1 year ago
LGTM! I'll wait to approve until you test, but it looks reasonable.
My only concern is about what happens for new releases of Crossplane. Will it be a lot of work to update the vendored code? Would it help to document anything about the process you followed to do the update, or is just something that we need to work through?
My only concern is about what happens for new releases of Crossplane. Will it be a lot of work to update the vendored code? Would it help to document anything about the process you followed to do the update, or is just something that we need to work through?
It's incredibly unclear what the LOE is to update the next time around. Regarding documentation, I don't really know what to document:
My only concern is about what happens for new releases of Crossplane. Will it be a lot of work to update the vendored code? Would it help to document anything about the process you followed to do the update, or is just something that we need to work through?
It's incredibly unclear what the LOE is to update the next time around. Regarding documentation, I don't really know what to document:
* I updated a dependency. * Fixed compilation errors. * Copied code over and tore out things that "we didn't need". Still TBD if that plan worked.
OK, that's cool. No need to do anything to document it.
Should we do a new release of up in the near future?
Should we do a new release of up in the near future
That makes sense to me. Maybe sometime next week so that we can at the very least get fixes for #329 out.
@jastang I don't think we support multiple releases, looking at https://github.com/upbound/up/tags it looks like we are always going forward with versions, so nothing to backport to
Description of your changes
It's been a long time since dependencies were updated in this repo. Some of the consequences of that are:
329
The overarching goal of this PR is to get us roughly caught up on the crossplane/crossplane dependency which results in a cascade affect of the other dependencies needing to be updated.
In addition:
Fixes #329
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
make build test reviewable
Testing xpls
make build
See below screenshots, prior functionality appears to continue to work
Testing xpkg commands
a. Checking if #329 is resolved
ezgi-platform-ref-gcp.xpkg
file.up xpkg xp-extract --from-xpkg ezgi-platform-ref-gcp.xpkg
gzip --uncompress out.gz
out
file, then searched forstatus.atProvider.id
and found:b. Verified that I can push xpkg to registry
c. Verified that I can pull that xpkg into a control plane