Closed ulucinar closed 1 year ago
Removes the deferred File.Close call in cache.entry.writeObjects to decrease the # of simultaneously open files and wraps the error returned from cache.entry.appendToPackageJSON to provide more context.
File.Close
cache.entry.writeObjects
cache.entry.appendToPackageJSON
I have:
make reviewable
backport release-x.y
Tested with Go 1.18.10 on a test configuration package with the following command:
/tmp/up xpkg dep xpkg.upbound.io/upbound/provider-gcp
(I've initially observed this issue with up@v.17.0, which uses Go 1.18)
up@v.17.0
1.18
🚢
Description of your changes
Removes the deferred
File.Close
call incache.entry.writeObjects
to decrease the # of simultaneously open files and wraps the error returned fromcache.entry.appendToPackageJSON
to provide more context.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
Tested with Go 1.18.10 on a test configuration package with the following command:
(I've initially observed this issue with
up@v.17.0
, which uses Go1.18
)