Closed branden closed 1 year ago
Billing report saved to /Users/branden/Projects/up/upbound_billing_report.tgz
It may be nice to put the date in the tarball. For someone running this multiple times (e.g. three monthly reports for the quarter), it would be nice not to have to rename the file. This is a small suggestion -- it could happen in a future revision.
Branden --
I read through the code. Overall, it's super clear and well tested. Thank you!
That said, I'm not entirely clear on what the output is. From the sample output above, it looks like we're getting a "max usage" for the time period specified by the user. Is that right?
I thought we were going for total usage. So if someone has an EKS cluster for 30 days, they'd have 720 loop-hours of usage. Is that what you're producing, or are you producing "one EKS cluster"?
@AlainRoy The output is a series of events covering the billing period, with each event recording the maximum observed count of a GVK on an MCP within a given hour. This was what product requested, I'll follow up offline.
The output is a series of events covering the billing period, with each event recording the maximum observed count of a GVK on an MCP within a given hour. This was what product requested, I'll follow up offline.
So in my example, we'd have 720 events, each saying "1 EKS cluster"?
For the record, Branden and I talked and we're happy. We have an idea to add a summary of the time period in a separate file, but we can do that in the future -- no need to do it now.
Description of your changes
This adds an
up
subcommandspace billing get
for getting a billing report from an object storage API, with initial support for GCS. Support for AWS and Azure will be added in followup PRs.I have:
make reviewable
to ensure this PR is ready for review.backport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested