Use concrete types with destroyCmd.Run() - Githubissues

upbound / up

The @upbound CLI

Apache License 2.0

52 stars 41 forks source link

Use concrete types with destroyCmd.Run() #365

Closed branden closed 1 year ago

branden commented 1 year ago

Description of your changes

Fixes these errors:

up: error: space.destroyCmd.Run(): couldn't find binding of type kubernetes.Interface for parameter 0 of func(kubernetes.Interface, install.Manager) error(), use kong.Bind(kubernetes.Interface)

up: error: space.destroyCmd.Run(): couldn't find binding of type install.Manager for parameter 1 of func(*kubernetes.Clientset, install.Manager) error(), use kong.Bind(install.Manager)

I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[x] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

I ran up space destroy and verified that it got past the binding errors.