search

upbound / up

The @upbound CLI
Apache License 2.0
52 stars 41 forks source link

spaces: add bidirectional version constraints #376

Closed sttts closed 11 months ago

sttts commented 11 months ago
  1. cmd/up/space/version.go: static semver constraints against the chart
  2. spaces.upbound.io/up-version-constraints annotation on the chart: constraints against up.

Fixes https://github.com/upbound/mxe/issues/190.

sttts commented 11 months ago

It looks like since we aren't yet enforcing a less-than version constraint in up, we won't yet need to cut a new release with updated constraints when we release Spaces.

Right.

But I added https://github.com/upbound/up/pull/376/files#diff-73c5a5c16c72949218b0a84e291b541d8cf3305dc046be9b6ee06005bcb89ba1R46, but merely as an example. Not sure we have a reason yet. @tnthornton might know more.

sttts commented 11 months ago

Updated to not require v1.1 for now.

AlainRoy commented 11 months ago

@sttts -- This looks good, thanks!

To clarify though, I think we also need to make annotations on the charts. Is that right? If so, what do we need to do to make sure that we keep those annotations up-to-date when we do a release?