Closed tnthornton closed 11 months ago
I have:
make reviewable
make test
For xpkg building specifically:
cat example/crossplane.yaml apiVersion: meta.pkg.crossplane.io/v1 kind: Configuration metadata: annotations: guide: quickstart provider: aws vpc: default name: getting-started-with-aws spec: crossplane: version: '>=v1.0.0-0' dependsOn: - provider: xpkg.upbound.io/crossplane-contrib/provider-helm version: '>=v0.15.0' - provider: xpkg.upbound.io/crossplane-contrib/provider-kubernetes version: '>=v0.9.0' - function: xpkg.upbound.io/crossplane-contrib/function-patch-and-transform version: '>=v0.1.3'
--- apiVersion: meta.pkg.crossplane.io/v1 kind: Configuration metadata: annotations: guide: quickstart provider: aws vpc: default creationTimestamp: null name: getting-started-with-aws spec: crossplane: version: '>=v1.0.0-0' dependsOn: - provider: xpkg.upbound.io/crossplane-contrib/provider-helm version: '>=v0.15.0' - provider: xpkg.upbound.io/crossplane-contrib/provider-kubernetes version: '>=v0.9.0' - function: xpkg.upbound.io/crossplane-contrib/function-patch-and-transform version: '>=v0.1.3' ---
Check results against an older version of up
--- apiVersion: meta.pkg.crossplane.io/v1 kind: Configuration metadata: annotations: guide: quickstart provider: aws vpc: default creationTimestamp: null name: getting-started-with-aws spec: crossplane: version: '>=v1.0.0-0' dependsOn: - provider: xpkg.upbound.io/crossplane-contrib/provider-helm version: '>=v0.15.0' - provider: xpkg.upbound.io/crossplane-contrib/provider-kubernetes version: '>=v0.9.0' - version: '>=v0.1.3' ---
NOTE ☝️ the lack of the function dependsOn entry.
Description of your changes
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
make test
For xpkg building specifically:
Check results against an older version of up
NOTE ☝️ the lack of the function dependsOn entry.