Closed tnthornton closed 10 months ago
Wait, I looked that the PRs in the wrong order: this overlaps #388. I'm guessing this PR needs to be updated? Maybe you should ignore my approval there.
Wait, I looked that the PRs in the wrong order: this overlaps https://github.com/upbound/up/pull/388. I'm guessing this PR needs to be updated? Maybe you should ignore my approval there.
Ya, this is branched from #388 and builds on that guy. I called that out in the description too 👍 . I'm guessing this is the reason for this comment:
One question: The description for the PR sounds much more limited than what is actually here. Is the description wrong, or did you not intend to include everything in this PR? I'm okay with it all being included, just making sure it's what you expect.
?
Wait, I looked that the PRs in the wrong order: this overlaps #388. I'm guessing this PR needs to be updated? Maybe you should ignore my approval there.
Ya, this is branched from #388 and builds on that guy. I called that out in the description too 👍 . I'm guessing this is the reason for this comment:
One question: The description for the PR sounds much more limited than what is actually here. Is the description wrong, or did you not intend to include everything in this PR? I'm okay with it all being included, just making sure it's what you expect.
?
Yeah, I just got confused since it's awaiting the merge, so there was more code. It all looks good though.
Description of your changes
This PR shuffles the subcommands around a little. This is in anticipation of some reworking for
ctp connect
.This changeset builds on #388. #388 should be merged/reviewed prior to this PR.
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested