Closed tnthornton closed 10 months ago
One other question: did you also test with cloud control planes to ensure they work? They demo only showed spaces.
Yep! Called that out in the description too:
- Verified functionality was consistent between spaces and cloud.
Description of your changes
In order to make it easier to interact with a control plane, we're introducing a new command and bringing back a previous command with different behavior.
Connect
up ctp connect {name}
has been reworked to connect the operators local kubeconfig to the target control plane. From a UX perspective, this means that an operator can simply point to a control plane and easily begin working within it.Disconnect
up ctp disconnect
has been introduced to easily allow the operator to switch back to the previous context they were using before initiating theconnect
command. This makes switching between target a control plane and another kubernetes cluster, quick and frictionless.Fixes #391
I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Introduced new tests
Captured the below video working against a local space https://github.com/upbound/up/assets/2375126/1fbe5e6c-09e6-4289-9d75-a7f8a178aae6
Verified functionality was consistent between spaces and cloud.