We'd like to enable operators to install the mcp-connector into App Clusters pointing to a Space control plane. In order to accomplish that, we needed to slightly extend what the current up ctp connector install command is doing and allow passing in:
--control-plane-secret={secret name}
so that an operator can supply the control plane secret.
In addition, we wanted to make it easier to uninstall the mcp-connector. To accomplish this a new subcommand up ctp connector uninstall was introduced.
[x] Run make reviewable to ensure this PR is ready for review.
How has this code been tested
Verify commands exist
./_output/bin/darwin_arm64/up ctp connector --help
Usage: up controlplane (ctp) connector <command>
Connect an App Cluster to a managed control plane.
Flags:
-h, --help Show context-sensitive help.
--format="default" Format for get/list commands. Can be: json, yaml, default
-v, --version Print version and exit.
-q, --quiet Suppress all output.
--pretty Pretty print output.
--domain=https://upbound.io Root Upbound domain ($UP_DOMAIN).
--profile=STRING Profile used to execute command ($UP_PROFILE).
-a, --account=STRING Account used to execute command ($UP_ACCOUNT).
--insecure-skip-tls-verify [INSECURE] Skip verifying TLS certificates ($UP_INSECURE_SKIP_TLS_VERIFY).
-d, --debug=INT [INSECURE] Run with debug logging. Repeat to increase verbosity. Output
might contain confidential data like tokens ($UP_DEBUG).
Commands:
controlplane (ctp) connector install Install mcp-connector into an App Cluster.
controlplane (ctp) connector uninstall Uninstall mcp-connector from an App Cluster.
Description of your changes
We'd like to enable operators to install the mcp-connector into App Clusters pointing to a Space control plane. In order to accomplish that, we needed to slightly extend what the current
up ctp connector install
command is doing and allow passing in:so that an operator can supply the control plane secret.
In addition, we wanted to make it easier to uninstall the mcp-connector. To accomplish this a new subcommand
up ctp connector uninstall
was introduced.I have:
make reviewable
to ensure this PR is ready for review.How has this code been tested
Connect an App Cluster to a managed control plane.
Flags: -h, --help Show context-sensitive help. --format="default" Format for get/list commands. Can be: json, yaml, default -v, --version Print version and exit. -q, --quiet Suppress all output. --pretty Pretty print output.
-a, --account=STRING Account used to execute command ($UP_ACCOUNT). --insecure-skip-tls-verify [INSECURE] Skip verifying TLS certificates ($UP_INSECURE_SKIP_TLS_VERIFY). -d, --debug=INT [INSECURE] Run with debug logging. Repeat to increase verbosity. Output might contain confidential data like tokens ($UP_DEBUG).
Commands: controlplane (ctp) connector install Install mcp-connector into an App Cluster. controlplane (ctp) connector uninstall Uninstall mcp-connector from an App Cluster.
Check the volume has 'test' as the secretName:
Uninstall mcp-connector
kubectl -n kube-system get pods -o custom-columns="POD_NAME":".metadata.name" POD_NAME coredns-565d847f94-5tld8 coredns-565d847f94-92fc9 etcd-kind-control-plane kindnet-fwmqk kube-apiserver-kind-control-plane kube-controller-manager-kind-control-plane kube-proxy-jztks kube-scheduler-kind-control-plane