upbound / up

The @upbound CLI
Apache License 2.0
51 stars 41 forks source link

fix(spaces): Allow ctrl+c while running up space init #405

Closed cbuto closed 9 months ago

cbuto commented 9 months ago

Description of your changes

Allows using ctrl+c to interrupt the up space init command to allow stopping the installation without needing to kill the process via kill -9.

Note: this does not allow for re-initialization of the space, killing the process or using ctrl+c could result in the space being in a unstable state. It'll be a bit of work to make the up space init rerunnable/idempotent.

Fixes https://github.com/upbound/mxe/issues/257

I have:

How has this code been tested

manually running up space init then using ctrl+c to exit the process while prereqs are installing.

Upbound-CLA commented 9 months ago

CLA assistant check
All committers have signed the CLA.

sttts commented 9 months ago

Looks great! 🚢 it.