search

upbound / up

The @upbound CLI
Apache License 2.0
51 stars 41 forks source link

Update canned PR text #413

Closed chrishalbert closed 6 months ago

chrishalbert commented 7 months ago

What happened?

While submitting and pull request, I tried to run make reviewable locally. It looks like this may have been removed at some point. Also, there is versioning information that I'm unfamiliar with; perhaps that could also be modified, or elaborated upon for clarity sake.

Epic #

How can we reproduce it?

I left the canned PR checkboxes (unchecked) in https://github.com/upbound/up/pull/411

What environment did it happen in?

N/A - github conf

tnthornton commented 6 months ago

Hi @chrishalbert ! The reviewable target should be coming from the build git submodule. When you set up the repo locally, were you able to get a local copy of the build submodule pulled?

chrishalbert commented 6 months ago

Sorry about that! I jumped to conclusions a little too quick.

tnthornton commented 6 months ago

No worries!