search

upbound / up

The @upbound CLI
Apache License 2.0
51 stars 41 forks source link

`up xpkg build` breaks on Docker 25.0 #416

Closed nekr0z closed 4 months ago

nekr0z commented 6 months ago

What happened?

On Docker 25.0, attempting to up xpkg build --controller $something results in 

up: error: xpkg.buildCmd.Run(): unable to calculate manifest: blob sha256:whatever not found

Downgrading Docker to 24.0.7 restores normal behavior.

https://github.com/moby/moby/pull/44598 may be related, though I'm not sure.

nekr0z commented 6 months ago

Tentatively linking to https://github.com/google/go-containerregistry/issues/1870

bobh66 commented 6 months ago

@tnthornton - is there a reason that docker/docker is pinned back to v20.10? It is incompatible with v25+

tnthornton commented 6 months ago

@bobh66 it looks like we needed to pin it due to a transitive dependency from helm https://github.com/helm/helm/issues/11821. There's been some movement in that issue since, so maybe we can make some progress in removing that specific pin.

floric commented 4 months ago

Unfortunately we are also blocked to upgrade to Docker 25 by this issue. Upgrading Kind and the Up CLI to the latest versions didn't help. Is there any workaround available?

bobh66 commented 4 months ago

@jeanduplessis can we get some attention on this issue? It's affecting anyone with Docker 25 that is trying to build a provider.

nekr0z commented 4 months ago

The patch is trivial, and compiling a patched up version is not that hard, really...

a1994sc commented 4 months ago

I am still seeing this error:

docker version
Client: Docker Engine - Community
 Version:           26.0.0
 API version:       1.45
 Go version:        go1.21.8
 Git commit:        2ae903e
 Built:             Wed Mar 20 15:19:57 2024
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          26.0.0
  API version:      1.45 (minimum version 1.24)
  Go version:       go1.21.8
  Git commit:       8b79278
  Built:            Wed Mar 20 15:18:11 2024
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.28
  GitCommit:        ae07eda36dd25f8a1b98dfbf587313b99c0190bb
 runc:
  Version:          1.1.12
  GitCommit:        v1.1.12-0-g51d5e94
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
up version
Client Version: v0.27.0
Server Version: v1.15.1
17:11:49 [ .. ] Building package provider-nexus-v0.0.9-8.g2bfffb7.dirty.xpkg for linux_amd64                                                                                
up: error: xpkg.buildCmd.Run(): unable to calculate manifest: blob sha256:1fa3e5e154fa4fb478d729e9f39c290f37f3d6778c5e9d99615821caec853f31 not found
17:11:51 [FAIL]
make[3]: *** [build/makelib/xpkg.mk:87: xpkg.build.provider-nexus] Error 1
make[2]: *** [build/makelib/common.mk:337: do.build.artifacts.linux_amd64] Error 2
make[1]: *** [build/makelib/common.mk:347: build.all] Error 2
make: *** [build/makelib/common.mk:353: build] Error 2