upbound / up

The @upbound CLI
Apache License 2.0
51 stars 41 forks source link

space subcommands should respect 'groups' #420

Closed tnthornton closed 6 months ago

tnthornton commented 6 months ago

Description of your changes

With Spaces 1.2, 'groups' are introduced. Unfortunately, that means many of the related commands no longer work. This changeset attempts to address that.

Highlevel changes:

I have:

How has this code been tested

  1. Update unit test - all pass
  2. Ran through various commands called out below

up ctp get

./_output/bin/darwin_arm64/up ctp get one
Control plane one not found

./_output/bin/darwin_arm64/up ctp get two -g two
Control plane two not found

./_output/bin/darwin_arm64/up ctp list
No control planes found

./_output/bin/darwin_arm64/up ctp list -A
No control planes found

up ctp create one

./_output/bin/darwin_arm64/up ctp create one
one created

up ctp create two -g two

./_output/bin/darwin_arm64/up ctp create two -g two
two created

up ctp list

./_output/bin/darwin_arm64/up ctp list
NAME   ID                                     GROUP     STATUS     MESSAGE                                                                                                                                 CONNECTION NAME
one    8ccaec1c-2550-4f68-9531-e188394490c8   default   Creating   Waiting for start up: Unready resources: admin-services, admin-services-uses-kube-control-plane, get-backup-configuration, and 5 more   kubeconfig-one

./_output/bin/darwin_arm64/up ctp list -A
NAME   ID                                     GROUP     STATUS     MESSAGE                                                                                             CONNECTION NAME
one    8ccaec1c-2550-4f68-9531-e188394490c8   default   Creating   Waiting for start up: Unready resources: admin-services, kube-control-plane, and xmanagedServices   kubeconfig-one
two    3048d360-488d-48ee-b7ba-591757f8182e   two       Creating   Waiting for start up                                                                                kubeconfig-two

up ctp connect one

./_output/bin/darwin_arm64/up ctp connect one

kubectl get ns
NAME                STATUS   AGE
crossplane-system   Active   3m33s
default             Active   4m2s
kube-node-lease     Active   4m2s
kube-public         Active   4m2s
kube-system         Active   4m2s
upbound-system      Active   3m33s

up ctp connect two -g two

./_output/bin/darwin_arm64/up ctp connect two -g two

kubectl get ns
NAME                STATUS   AGE
crossplane-system   Active   3m10s
default             Active   3m35s
kube-node-lease     Active   3m35s
kube-public         Active   3m35s
kube-system         Active   3m35s
upbound-system      Active   3m10s

up ctp delete two -g two

./_output/bin/darwin_arm64/up ctp delete two -g two
two deleted

up ctp delete one

./_output/bin/darwin_arm64/up ctp delete one
one deleted

./_output/bin/darwin_arm64/up ctp list -A
NAME   ID                                     GROUP     STATUS     MESSAGE   CONNECTION NAME
one    8ccaec1c-2550-4f68-9531-e188394490c8   default   Deleting             kubeconfig-one
two    3048d360-488d-48ee-b7ba-591757f8182e   two       Deleting             kubeconfig-two

./_output/bin/darwin_arm64/up ctp get two -g two
NAME   ID                                     GROUP   STATUS     MESSAGE   CONNECTION NAME
two    3048d360-488d-48ee-b7ba-591757f8182e   two     Deleting             kubeconfig-two