Add step to wait for PackageRevisions to be healthy

upbound / up

The @upbound CLI

Apache License 2.0

51 stars 41 forks source link

Add step to wait for PackageRevisions to be healthy #422

Closed tnthornton closed 6 months ago

tnthornton commented 6 months ago

Description of your changes

We've had some internal reports of migration not working, with what appears to be a race between attempting to apply resources prior to the APIs being available. This changeset adds a step to wait for the various PackageRevisions to be healthy before moving on.

I have:

[X] Read and followed Upbound's contribution process.
[X] Run make reviewable to ensure this PR is ready for review.

How has this code been tested

turkenh commented 6 months ago

Thanks for the PR @tnthornton 🙌

it's very missleading that Providers,Functions, Configurations Healthy / Installed when the Revisions Not in this Status ..

I couldn't reproduce this with Crossplane v1.14 but able to reproduce with Crossplane 1.13. So, the good news is this is something already fixed in the latest version presumably with this PR.