Do not restore package statuses and use the same confirmation dialog as spaces init - Githubissues

upbound / up

The @upbound CLI

Apache License 2.0

52 stars 41 forks source link

Do not restore package statuses and use the same confirmation dialog as spaces init #426

Closed turkenh closed 8 months ago

turkenh commented 8 months ago

Description of your changes

This PR is a follow up on the problem described in https://github.com/upbound/up/pull/422 during import:

Do not restore status for base resources
- Otherwise, packages reported as installed/healthy before they were actually processed.
- No need for restoring status for any other base resources, so, disabled all together.
Unifies the confirmation dialog as spaces init
- To confirm exporting secrets.
- When preflight checks failed during import.

I have:

[x] Read and followed Upbound's contribution process.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Create a control plane
Stop Crossplane
Import
Ensure it waits successfully.

github-actions[bot] commented 8 months ago

Successfully created backport PR #427 for release-0.24.