upbound / up

The @upbound CLI
Apache License 2.0
50 stars 42 forks source link

nodeSelector for setting up IngressNginx #432

Open haarchri opened 4 months ago

haarchri commented 4 months ago

What happened?

s there a specific reason we're using a nodeSelector for setting up IngressNginx? While I see its relevance for local Kind installations, I'm puzzled about its necessity in environments like AWS, GCP, or Azure.

    nodeSelector := map[string]any{
        "ingress-ready": "true",
    }

https://github.com/upbound/up/blob/2f6dd6628a12cbe53ef65d56d3c8b0e8f5dc729f/cmd/up/space/prerequisites/ingressnginx/ingressnginx.go#L161

for reference the default helm-chart configuration for IngressNginx https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/values.yaml#L991

Epic #

How can we reproduce it?

What environment did it happen in?

haarchri commented 4 months ago

image