The current logic for setting path to up in the Kubeconfig AuthInfo exec switches depending on the target release version. If we are on the release build, then use "up". If we are on the debug build, then use the current executable path. This has unfortunate side effects when customers use up but don't have the CLI in PATH - the AuthInfo won't ever be able to resolve the exec.
This change standardises the mechanism regardless of release target. The AuthInfo will always fall back to the full path of the up executable, unless we can guarantee we're running it from PATH.
Description of your changes
Fixes https://github.com/upbound/up/issues/490
The current logic for setting path to
up
in the Kubeconfig AuthInfo exec switches depending on the target release version. If we are on therelease
build, then use"up"
. If we are on thedebug
build, then use the current executable path. This has unfortunate side effects when customers useup
but don't have the CLI inPATH
- the AuthInfo won't ever be able to resolve the exec.This change standardises the mechanism regardless of release target. The AuthInfo will always fall back to the full path of the
up
executable, unless we can guarantee we're running it fromPATH
.I have:
make reviewable
to ensure this PR is ready for review.Addedbackport release-x.y
labels to auto-backport this PR, as appropriate.How has this code been tested
Running from
PATH
:Running from pwd: