`space init` add prometheus scrape annotations to initialized provider-kubernetes/helm

upbound / up

The @upbound CLI

Apache License 2.0

49 stars 42 forks source link

`space init` add prometheus scrape annotations to initialized provider-kubernetes/helm #539

Closed lsviben closed 4 weeks ago

lsviben commented 1 month ago

What problem are you facing?

With Spaces adding Space level telemetery, it will scrape all Spaces machinery pods with the prometheus scrape annotations set. Add those to the providers initialised during space init.

How could Upbound help solve your problem?

Add the labels.

Epic https://github.com/upbound/spaces/issues/934

lsviben commented 1 month ago

Ran

up space init --token-file="../key.json" "v1.4.0-rc.0.331.g417a41db" \
  --set "account=bob" \
  --set "features.alpha.observability.enabled=true"

and noticed that annotations are already set? not sure where they came from, but maybe this ticket is not needed

lsviben commented 4 weeks ago

This one is not needed as the annotations exist already.