Avoid the surprise of seeing different Spaces in the console vs. up ctx by listing unreachable items for Spaces that are unreachable or for which we failed to find the ingress. Sort these items to the end of the list so that all the selectable items are at the top.
[x] Run make reviewable to ensure this PR is ready for review.
[ ] Added backport release-x.y labels to auto-backport this PR, as appropriate.
How has this code been tested
Manual testing with organizations that have many unreachable Spaces. Also tested the other menus that may have unselectable items to make sure it all looks good.
Description of your changes
Avoid the surprise of seeing different Spaces in the console vs.
up ctxby listing unreachable items for Spaces that are unreachable or for which we failed to find the ingress. Sort these items to the end of the list so that all the selectable items are at the top.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested
Manual testing with organizations that have many unreachable Spaces. Also tested the other menus that may have unselectable items to make sure it all looks good.