gitTag resource is broken + gitHubrelease does not filter when falling back to git tag

[dduportal]

Describe the bug

The GitHub Actions run https://github.com/updatecli/updatecli/runs/4531357392?check_suite_focus=true fails because it gets a source version for golang which is go-1.18beta1 which is unexpected.

The manifest file at https://github.com/updatecli/updatecli/blob/7ab1dad47464117af5aea0e6c1a648900a8511a7/updatecli/updatecli.d/golang.yaml#L13 defines a pattern constraint that should not catch go-1.18beta1 but go-1.17.5 instead.

I guess it's related to #182 : as there are no github release in https://github.com/golang/go, then updatecli falls back to git tags. But the pattern filtering is NOT applied to this fallback, which causes this bug.

I wanted to switch to using pure git tags but:

• The doc is incorrect: https://www.updatecli.io/docs/resources/gittag/ (it references githubrelease 😅🤔)
• gitTag resource seems broken when specifying a tag filter:

SOURCES
=======

latestGoVersion
---------------
WARNING: no git tag message specified
Searching for version matching pattern "latest"
✗ No Git Tag found matching pattern "latest"
ERROR: ✗ no Git tag found matching pattern "latest"

Steps to Reproduce

See bug description: there is a permalink to the failing manifest. You can only keep the first source of this manifest file to reproduce quickly.

Expected behavior

Either:

• Applies the filtering to the git tag fallback
• OR not falling back to git tags if it does not supports the filter and errors
  • In this case, I expect git tag to allow me to filter out

Screenshots

Version

• OS: linux, macOS
• Updatecli version: 0.16.1, 0.17.0

Additional context

[dduportal]

Closing, thanks to @lemeurherve 's help!

The pattern is badly shaped and should be: ^go-1\.(\d*)\.(\d*)$:

• Missing beginning (^) and end of line ($)
• The dot characters are litteral and should be escaped