search

updatecli / updatecli

A Declarative Dependency Management tool
https://www.updatecli.io
Apache License 2.0
534 stars 62 forks source link

Request reviewer on pull request creation #925

Open alecharp opened 1 year ago

alecharp commented 1 year ago

Is your feature request related to a problem?

I'm working on a project which is deployed thanks to pull request created by updatecli on a different repository. However, I'm not actively watching (maybe I should) that repository.

It is possible that a release should be skipped and the team handling the deployment is not aware of such situations. Having the team working on the project providing review whether the update is valid or not would facilitate the work of the SRE I work with (my opinion).

Solution you'd like

It would be great that the pull request created by updatecli have a review request section with a user list or a team. Combined with a branch protection and the auto-merge option, it would simplify the life of some SRE.

Alternatives you've considered

No response

Anything else?

No response

olblak commented 1 year ago

Thanks for the reporting this issue. When I worked on the GitHub Pull-request thing, I remember wondering if I wanted to do the extra mile to support assignee. The approach is a bit similar to the label, we first need to retrieve assigneeID before updating a pullrequest with the correct assignee. Like here

With the GitHub documentation here

For someone familiar with the Github Api v4, it's an easy to improvement to do.

Meanwhile I decided to rely on the CODEOWNER file :)

Regarding the automerge feature, it's already integrate in Updatecli and I use it in many places like explained on https://www.updatecli.io/docs/plugins/pullrequest/github/

alecharp commented 1 year ago

I'm not sure that the CODEOWNER would work here. The pull request which would be open would concern a different project than the one the pull request is opened in. To be specific:

I would be in the CODEOWNER of jenkins-infra/plugin-health-scoring but not on jenkins-infra/helm-charts. And my review would be an indication for the owners of jenkins-infra/helm-charts that the update is valid or not.

About the automerge, I saw the doc yes and used it on a pull request on jenkins-infra/helm-charts.