Fix the version constraint on ppx_expect

upenn-cis1xx / camelot

A fully-modular OCaml style linter

https://opam.ocaml.org/packages/camelot/

Apache License 2.0

44 stars 5 forks source link

Fix the version constraint on ppx_expect #53

Closed kit-ty-kate closed 3 years ago

kit-ty-kate commented 4 years ago

My fix to camelot.1.4.2 in opam-repository (https://github.com/ocaml/opam-repository/pull/16595#issuecomment-641613216) wasn't upstreamed.

I also have a question: given camelot currently seems to compile with OCaml 4.11, would it be ok to relax the constraint in opam-repository for its last version, or does it need some extra work for it to be compatible with OCaml 4.11?

Vighnesh-V commented 3 years ago

Welcome @kit-ty-kate! It's super exciting to see someone check out our repo :) We've been rather unresponsive recently but since the course that uses Camelot is over, we have some spare time now to get around to this!

The fix you suggested looks good, and I'm happy to look more deeply and merge it this weekend. I think Camelot should also be 4.11 compatible, but only if the 4.11 Parsetree hasn't changed. If the code compiles and passes tests on 4.11, I think it should be good.

kit-ty-kate commented 3 years ago

I unlocked the constraint for OCaml 4.11 here: https://github.com/ocaml/opam-repository/pull/16837. Feel free to open a PR to change it back if you feel it should not be compatible.