search

upenn-cis1xx / camelot

A fully-modular OCaml style linter
https://opam.ocaml.org/packages/camelot/
Apache License 2.0
44 stars 5 forks source link

No style violations message (fixes #59) #62

Closed esinx closed 3 years ago

esinx commented 3 years ago

On student_display I added a condition List.length l > 0 to check if any violation exists, and if not it will print a bold green text saying "No style violations". I did not add a new test case(we might need to create a new "perfect" case) but tested the executable directly to check.

Vighnesh-V commented 3 years ago

Don't worry about adding a new test case - I think this should be ok (although I'll wait on the CI to verify this for us).

Thanks for this fix! You should see this in hw4 lol :) @KeenWill