upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Company of First Performance (Annals) (display) and filter #113

Closed ZacharyLesser closed 1 year ago

ZacharyLesser commented 1 year ago

Something has gone wrong with the data in this field (at the Title level in admin). A lot of the data is incorrect:

Wily Beguiled — Old DEEP: Children of Paul’s (Second) New DEEP: nothing in field

The Woman Hater — Old: Children of Paul’s (Second) New: King’s Men

Bussy D’Ambois — Old: Children of Paul’s (Second) New: nothing

Has the data in this field somehow gotten mixed up during the re-generating of the db?

ZacharyLesser commented 1 year ago

Six Court Comedies has data in this field -- but Collections should NEVER have data in this field since they cannot have a company of first performance (since they aren't plays, but collections of plays).

The data seems to have gotten off-track in some way.

ZacharyLesser commented 1 year ago

Taming of a Shrew -- Old DEEP: Unknown ; New DEEP: King's Men

ZacharyLesser commented 1 year ago

Not sure what's happened here. Perhaps we could create a spreadsheet with Work ID and Company of First Performance (Annals) Filter and Company of First Performance (Annals) Display -- I'm not sure we have an easy way to do that, though.

Is there some way to check whether just this field could be reimported from the old data without re-generating the entire db? that is, maybe we can redo this field and ensure that the correct data is assigned to the correct Titles based on the old data?

ZacharyLesser commented 1 year ago

I also see a field at the Item level called "Company" -- what is this field doing? It has data in the drop-down list that looks like display data (has multiple items separated by semicolons for example).

I suspect we need to systematically figure out how to assign the data properly for the following:

Item level: Company (Title Page Attribution) Filter [an object field] Company (Title Page Attribution) Display

Edition level: no fields necessary

Title level: Company First Performance (Annals) Filter [an object field] Company First Performance (Annals) Display Company First Performance (BritDrama) Filter [an object field] Company First Performance (BritDrama) Display

ZacharyLesser commented 1 year ago

The old data should match up as follows -- going from the old data field names to where they should end up in the new admin:

Display_Companies --> Company (Title Page Attribution) Display [at the Item level]

Display_Auspices --> Company of First Performance (Annals) Display [at the Title level]

Probably these as well:

Companies --> Company (Title Page Attribution) Filter [at the Item level] Auspice of First Production --> Company First Performance (Annals) Filter [at the Title level]

The fields relating to BritDrama appear to be working correctly and should just remain as is.