search

upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Stationer; Stationer: Printer; Stationer: Publisher; Stationer: Bookseller searches not working #122

Closed ZacharyLesser closed 1 year ago

ZacharyLesser commented 1 year ago

Printer, Publisher, and Bookseller searches need to generate a list of Filter Choices in the drop-down from the Filter field at Item level, and then search on the Filter field at Item level, and then display the Display field.

Stationer: Printer -- search on "Stationer printer" (and create the drop-down of choices from this field) Stationer: Publisher -- search on "Stationer publisher" (and create the drop-down of choices from this field) Stationer: Bookseller -- search on "Stationer bookseller" (and create the drop-down of choices from this field)

It looks like the Display field may have gotten mixed into the filter somehow. Have a look at DEEP 286. The names with (?) after them in Stationer printer Display are appearing in the Filter Choices for Printer on the user side.

ZacharyLesser commented 1 year ago

Just as a reminder, the general "Stationer" filter simply incorporates all name-objects in the "Stationer printer / publisher / bookseller" fields and filters on all three of those fields at once.

ZacharyLesser commented 1 year ago

There is also a zero that appears in the filter choices for Stationer, which should be removed (must be because of blank fields?)

ZacharyLesser commented 1 year ago

Even after running a build, any changes I make to the Stationer printer, publisher, bookseller fields do not seem to be taking effect. For instance, I tried replacing all the names in the Stationer printer Display field with "TEST" and ran a build and nothing changed on the front end. This is very odd. Is the display field somehow not being updated by the db???

apjanco commented 1 year ago

This should be fixed now. It was a side-effect of shifting the Stationer fields to objects. They are fixed now (but your browser's cache may still show entries with (?) in them. I did remove them and they'll go away, try crtl/command shift r to clear the cache). Please test and close if this is working right.