search

upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Not working: Play Type = Professional/Nonprofessional #148

Closed abfarmer109 closed 8 months ago

abfarmer109 commented 1 year ago

Searching/filtering for "Professional" and "Nonprofessional" in "Play Type" is not working. "Play Type = Professional" results in 1,483 records, many of which are not professional plays. "Play Type = Nonprofessional" also results in 1,483 records, many of which are not nonprofessional play.

Other specific play types in this search/filter all appear to be correct.

ZacharyLesser commented 1 year ago

At the edition level in the field Play Type: Filter, some records will have "Professional" or "Nonprofessional" as one of the terms. This term is generally accompanied by other terms. The problem appears NOT to be in the data (i.e., the correct term "professional" or "nonprofessional" is appearing in the Play Type: Filter field).

I am guessing this is the same problem as in #170 --because the code is looking for character strings rather than discrete tags, it is picking up "Professional" while looking for "Nonprofessional" (or vice versa)

Perhaps changing this to an object field will fix this (see #166 )?