search

upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Remove the bits of code that strip (?) out of the list of filter choices for various fields #168

Closed ZacharyLesser closed 7 months ago

ZacharyLesser commented 1 year ago

We are editing the "filter" fields directly to eliminate these question marks (which should only appear in data in the "display" version of these fields).

The code that is stripping out (?) while generating the drop-down list of filter choices seems to be causing other problems, especially with some items being omitted from the list of choices, and so we should remove this code since it will be made redundant anyway since we are taking care of this in the data. Taking care of it in the data rather than the code is a more efficient, streamlined way of handling it anyway and should be more sustainable.

ZacharyLesser commented 1 year ago

This may resolve some other issues like #157 and #161

ZacharyLesser commented 8 months ago

The issues listed in comment above have already been resolved -- still, if there is code that strips (?) out when generating the list of filter choices, it can be removed. This will let us see which filter terms still have the (?) and we can deal with it manually in the data.