upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Theater (Title Page) not working properly #173

Closed ZacharyLesser closed 8 months ago

ZacharyLesser commented 1 year ago

This search was not working properly, and I realized that the "Theater Type" field is obsolete anyway. I added "Indoor Professional" and "Outdoor Professional" to the "Theater" field as filter choices. So the entire filter can now work simply on "Theater" (at Item level).

Here's what we need to do:

1) Delete the "Theater Type" field from the db

2) Filter on "Theater" field (at Item level). If ANY data is present in that field = Any; if NO data is present in that field = None

3) Retain the existing layout of the drop-down of filter choices, with Any, None; blank line; Indoor Professional, Outdoor Professional, before the Court, at University; blank line; [alphabetical listing of theater names]

ZacharyLesser commented 1 year ago

Build appears to be broken for this filter. It does not rebuild the drop-down choices, and the theaters result in zero hits.

ZacharyLesser commented 8 months ago

Filter on "None" returns results that are "before the Court" and "at University" -- these should not be included.

"None" = no data at all present in "Theater" (at Item level)

apjanco commented 8 months ago

Let's look at this when we talk. When Theater (Title Page) is set to "None" the filter is item.theater equals "None" OR item.theater_type equals "None"

ZacharyLesser commented 8 months ago

Theater type field should be obsolete now because I moved all that data into Theater. I think this is the problem because with that field still involved in the filter, there will be some false positives. Cutting that from the filter may solve the problem immediately

ZacharyLesser commented 8 months ago

ie change to

When Theater (Title Page) is set to "None" the filter is item.theater equals "None"

(but as usual, "None" here just means no data present, not the term "None")