upenndigitalscholarship / deep

https://deep.pennds.org/
MIT License
3 stars 1 forks source link

Theater (Title-Page Attribution) filter terms not correct #34

Closed ZacharyLesser closed 1 year ago

ZacharyLesser commented 1 year ago

When you try to filter on "Theater (Title-Page Attribution)", the list of choices in the drop-down is not correct. Compare to the old site. The list in the drop-down should be ordered as follows.

Any None

Indoor Professional
Outdoor Professional
before the Court
at University

Blackfriars Curtain Fortune Globe Paul's Phoenix/Cockpit Red Bull Rutland House Salisbury Court St. Werburgh Street, Dublin Swan Whitefriars Whitehall

ZacharyLesser commented 1 year ago

The first two terms in the second group "Indoor Professional" and "Outdoor Professional" are determined by the table, Theater Type -- if it says "Both Indoor and Outdoor" then it should be hit by either "Indoor Professional" or "Outdoor Professional". The terms in the "Theater Type" field, note, are NOT themselves shown in the list of filter terms

The rest of the terms are determined by the field "Theater" (which should be renamed Theater: Filter terms).

In "Theater" (soon to be Theater: Filter terms) there may be an issue with the way the data was imported. This field can have multiple terms in it (e.g., "before the Court; Globe") -- currently these are in a string, separated by a semicolon. It would be better if these were two discrete entries here, since they are multiple filter terms, and they do not display. (i.e., exactly the way "Authors" at the Edition level is currently working)

apjanco commented 1 year ago

fixed, outdoor professional == outdoor && both outdoor and indoor. But broke later conditions, need to fix

apjanco commented 1 year ago

Actually working fine in dev, check later that update is working as expected in prod.