upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Stationer filter not working correctly #54

Closed ZacharyLesser closed 1 year ago

ZacharyLesser commented 1 year ago

The Stationer filter is not currently working because it is not populated with the data from the data tables. The appearance of the filter is correct, with Printer, Publisher, and Bookseller indented slightly below Stationer.

1) The data fields "Stationer: Printer" , "Stationer: Publisher" , and "Stationer: Bookseller" need to all be converted to filter tables that can include multiple discrete items (exactly as "Authors" is functioning right now)

2) The filter choice list for "Stationer" is composed of all of the names that appear in any one of these three fields, removing any duplicate appearances of these names

3) The filter choice list for each of the three indented terms if selected alone is composed of all the names that appear in that data field

ZacharyLesser commented 1 year ago

The data tables for Stationer: Printer, and Stationer: Publisher, and Stationer: Bookseller need to enable multiple discrete terms (i.e., exactly the way "Authors" at the Edition level is currently working)

ZacharyLesser commented 1 year ago

FYI this was part of the idea behind the People table. I'm not sure if we are actually using that table at all. It was created new for this update to encompass anyone who is a person. We could then add further data to each person (a little bio, e.g., if we wanted that to pop up about the person, or a link to an external resource). These People would include all the Stationers, but also Authors, and people who wrote Paratextual Material, etc. Any person. Then in Stationer or Author or any other field, we could pull a name from People to populate that field.

I'm not sure if this is really necessary or if we are still planning to implement this at this stage, but that was the original idea that Scott had, and that's why there is a People table which probably is not being used at all right now(?)