upenndigitalscholarship / deep

MIT License
3 stars 1 forks source link

Book and Play Edition Number search should not include "n/a" or 0 #96

Closed ZacharyLesser closed 1 year ago

ZacharyLesser commented 1 year ago

If I search for Book Edition Number = second-plus, I get a lot of Plays in Collection in the results, I guess because they have "n/a" in the Book Edition Number field?

Search for Book Edition Number -- or Play Edition Number -- needs to exclude all Items with "n/a" in that field. The same error results in Collections being included in Play Edition Number = second-plus, since they have "n/a" in that field.

So "Second-plus" needs to equal "integers greater than 1", not "anything that isn't = 1" for this reason. Perhaps that's the logic error in the code?

ZacharyLesser commented 1 year ago

This seems to have been fixed by making Book Edition and Play Edition = 0 in cases of "n/a" -- this might work well for filtering purposes.

BUT: for display purposes, any time there is a zero in one of these fields, it should display as "n/a" not as a zero

Alternatively you can replace zero with "n/a" in the data itself, so long as the Filter can exclude any items with "n/a" in the field.

ZacharyLesser commented 1 year ago

The "0" should also not appear in the list of filter choices in the drop-down.

The easiest thing may be to substitute "n/a" for "0" in the data itself, but exclude it from the list of filter choices and have the searches for Book Edition Number and Play Edition Number ignore anything that is not a numeral / integer in the data field?