search

uperl / Alien-Librdkafka

alien wrapper to build and access librdkafka from perl
2 stars 2 forks source link

v0.11.6 -> v1.1.0 #5

Closed GeorgeShagov closed 5 years ago

GeorgeShagov commented 5 years ago

Not tested I manually copied src archive location from: https://github.com/edenhill/librdkafka/releases

GeorgeShagov commented 5 years ago

No, of cause not. It wasn't an intent. Pls do tar ball.

Changed to tbz

On Tue, 16 Jul 2019, 17:00 Graham✈️✈️, notifications@github.com wrote:

@plicease commented on this pull request.

In Build.PL https://github.com/plicease/Alien-Librdkafka/pull/5#discussion_r303925670 :

@@ -22,8 +22,8 @@ my $builder = Alien::Base::ModuleBuild->new( alien_isolate_dynamic => 1, alien_repository => { protocol => 'https',

Is there a reason to use the .zip here instead of .tar.gz? The latter is usually more reliable than the former.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/plicease/Alien-Librdkafka/pull/5?email_source=notifications&email_token=AJNIJOOW5N3GDXBMIYNQBC3P7XIBBA5CNFSM4IEBES32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6SHYLQ#pullrequestreview-262437934, or mute the thread https://github.com/notifications/unsubscribe-auth/AJNIJOJBLNPEQRZ5J4LLIDDP7XIBBANCNFSM4IEBES3Q .

plicease commented 5 years ago

Thanks for updating that. Can you please rebase on master? There is a CI fix that should allow your branch to build cleanly.

GeorgeShagov commented 5 years ago

7

plicease commented 5 years ago

btw- in the future you can force-push to the same branch to update the PR, rather than opening a new one.