Several updates/fixes to example script

uperl / AnyEvent-WebSocket-Client

WebSocket client for AnyEvent

9 stars 10 forks source link

Several updates/fixes to example script #29

Closed kyzn closed 7 years ago

kyzn commented 7 years ago

Thanks for maintaining this module! It was my CPAN pull request challenge assignment for the month, and I realized example script wasn't working properly. So I went ahead and figured out why, and rewrote a few methods to fix it.

Let me know if you want me to update anything. Thanks!

plicease commented 7 years ago

Thanks! I wrote this example a while ago and Mojolicious has obviously altered its API a bit since then. I had one comment so far and will review this more closely when I get back home this week, but this looks very good!

plicease commented 7 years ago

I made one minor tweak based on my comment earlier and merged. Thanks again.

kyzn commented 7 years ago

Thanks! I guess in that case we wouldn't need last two lines too:

@@ not_found.html.ep
Not found

plicease commented 7 years ago

Yeah I debated that. It actually uses the not_found template when you reply with not found.