search

uperl / AnyEvent-WebSocket-Client

WebSocket client for AnyEvent
9 stars 10 forks source link

create non mojo version of t/mojo_close.t #7

Closed plicease closed 7 years ago

jjatria commented 8 years ago

Oh, I just noticed this. I used mojo_close.t as the base for the tests of my recent pull request (#23). Should those tests be re-worked as well?

jjatria commented 7 years ago

I could help with this. If it's alright with you, I'll give it a shot and report back when I have something to show.

Any pointers welcome!

plicease commented 7 years ago

@jjatria just some background, the idea originally in using Mojolicious to test was that there was an existing pretty good implementation of websockets to test against/with. Unfortunately the mojo project had the habit of frequently making breaking changes, so I wanted to have something more stable to test against. I still think this would be a good idea, but on the other hand the mojo project seems to have stabilized somewhat as well, so it definitely does not seem as urgent as it once did. If you take a look you will see there are pairs with equivalent testing going on, for example: ae.t / mojo.t and ae_ssl.t / mojo_ssl.t . Ideally we'd have ae.t equivalents to all of the mojo.t tests.

So if you have time and the interest, I am always glad to see improvements submitted to my dists!