pass more stuff information into the on_message / on_next_message callback

[plicease]

Possible things that might be of use

• the connection object
• what sort of message it is (text/binary, etc)

[plicease]

If anything else is passed in it should be compatible with the current implementation, so $_[0] should be the decoded message.

[debug-ito]

I was thinking about that, too.

I tried implementing new methods on_next_data() and on_each_data() to do a bit rawer handling of received data. Checkout https://github.com/debug-ito/AnyEvent-WebSocket-Client/tree/connection_raw_data

In on_{next,each}_data() callbacks,

• $_[0] is a raw non-decoded byte string
• $_[1] is the type of the frame ("text" or "binary")

But yeah, passing the connection object is a good idea (it reduces the risk of cyclic reference)

[plicease]

I took what you did and reworked the interface, take a look at my issue_8 branch.

• implementing the old onmessage methods in terms of the new so there is less complexity in the message processing, but each onmessage callback calls decode, so they should be be deprecated
• I don't like "data" as an event name so reworked the interface so your data events can be called message events (on(each_message => instead of on_each_message)
• will almost certainly rework the Message class (don't really like the type method, will probably instead use is_text / is_binary instead)
• documentation for change is incomplete and probably out of sync

Does this interface meet your needs? I haven't committed to it yet, but I think it is close to what I am thinking.

[debug-ito]

Yes, it meets my needs. I like the idea of on() method. Thank you!

[plicease]

Cool. Your test was really helped out thanks for that