uperl / Kafka-Librd

perl bindings to librdkafka
11 stars 8 forks source link

Better test coverage #18

Open eserte opened 5 years ago

eserte commented 5 years ago

It would be nice to further increase test coverage. To do so I think we have to run tests against a real kafka server. There's some work in progress to implement this: https://github.com/idealo/Kafka-Librd/blob/more-testing-with-broker/t/fulltest.t This test script starts zookeeper and kafka on the fly with temporary directories and ports, and runs some Kafka::Librd commands on this.

However a lot of polishing is still needed:

plicease commented 5 years ago

Thanks for opening this, I was thinking along these lines as well.

It would be nice (esp. for CI, but also for local dev) to be able to test against a kafka docker instance to avoid the dependencies on zookeeper etc. I did some minimal poking around on dockerhub and didn't find anything that looked well supported or recent though.

Agree that live testing against real kafka server should happen in CI plus with an appropriate Kafka::Librd specific environment variable for developers. Obviously don't want to be clever and detect an instance that turns out to be a server handling production traffic.