search

uperl / Kafka-Librd

perl bindings to librdkafka
11 stars 8 forks source link

Implement last_error #34

Closed harmathy closed 3 years ago

harmathy commented 3 years ago

This implements rd_kafka_last_error as Kafka::Librd::Error::last_error. The result can be used with Kafka::Librd::Error::to_string. There are unit tests and POD.

This should fix #33.

plicease commented 3 years ago

I'm not crazy about how the (existing) error package is organized, but for the documentation lets fully spell out the function name at the =head2 level.

Sorry the CI is taking forever because it is on the old travis-ci infrastructure. I've migrated it to the newer .com which should be faster. If you fix that documentation and push the commit to this branch then it should hopefully run CI on the newer faster infrastructure. I hope?

harmathy commented 3 years ago

I changed the headings to use the full function names. Also there were doubled headings (probably artefacts from git rebase).

plicease commented 3 years ago

I've released your changes with 0.17_01 (0.16_01 was a bad release, please ignore it). This is a dev release. Once it has had some testing in cpantesters I will make a production release. If I haven't made a production release in a week or so, please feel free to bump this issue.